search

tomaka / vorbis-rs

Rust bindings for libvorbis
Apache License 2.0
15 stars 12 forks source link

Fix typo in VorbisQuality enum #13

Closed jhoudan closed 2 years ago

jhoudan commented 7 years ago

First things first, thank you for your work! I'm using rodio and vorbis in a side project, it's a pleasure to work with both those libraries.

This MR intends to fix a small typo in the VorbisQuality enum. I'm not entirely sure of "Midium" (should it be "Medium"?) as english is not my mother tongue.

This change may break the code of people using this library though, so feel free to close this MR if you don't want to bother bumping the major version just for a typo fix.

tomaka commented 7 years ago

Thanks for the PR.

This change may break the code of people using this library though, so feel free to close this MR if you don't want to bother bumping the major version just for a typo fix.

You're right. This should probably be merged & published at the same time as another change and not alone.