Update to Rust 2018 and make encoding an optional feature

tomaka / vorbis-rs

Rust bindings for libvorbis

Apache License 2.0

15 stars 12 forks source link

Update to Rust 2018 and make encoding an optional feature #18

Closed AlexApps99 closed 3 years ago

AlexApps99 commented 4 years ago

Note: this PR supersedes #17 and #13

This PR:

Creates an optional (enabled by default) encoder feature
Updates the crate to Rust 2018
Removes rand from dependencies and into dev-dependencies
Fixes two typos made within the encoding section (including one #13 failed to correct)
Updates all crates to most recent versions, vorbis-encoder is updated to Git master as crates.io version has outdated vorbis-sys

If needed, I can also apply cargo fmt before merging this PR.

This closes #16

AlexApps99 commented 4 years ago

@tomaka Are there any modifications I should apply to this PR?

Hossein-Noroozpour commented 4 years ago

Hi it seems good. Thanks.

AlexApps99 commented 4 years ago

@tomaka apologies for pinging you again, but it's been a few months, wondering if you're ok with this PR?

roderickvd commented 3 years ago

@tomaka are you still maintaining this repository?

@Hossein-Noroozpour could you update vorbis-encoder and even better, create a public repository for it? It currently is in dependency hell over vorbis-sys.

@AlexApps99 see further and partly conflicting work in #20, I propose that if this is no longer maintained then someone forks it. At this point this crate simply doesn't work on newer Rust versions.

AlexApps99 commented 3 years ago

I lost interest in this crate and wrote my own a while ago (don't think I uploaded it), feel free to fork if you want. I'll close this PR in the mean time.

roderickvd commented 3 years ago

That's a pity. Regardless of your personal interest, your work is sound and should be merged.

AlexApps99 commented 3 years ago

If you wish to make a fork, feel free to use whatever is in this PR. Sadly these crates seem to be abandoned by tomaka