Annoying `ShapelyDeprecationWarning`

Description

Using recent versions of shapely (here 1.8.2), every time snkit.network.split_edge_at_points is used, the following warning is shown:

ShapelyDeprecationWarning: GeometryTypeError will derive from ShapelyError and not TypeError or ValueError in Shapely 2.0.
  raise GeometryTypeError("Splitting a LineString with a %s is not supported" % splitter.type)

This relates to the attempts to harmonize the handling of errors in shapely, see the related issue. I didn't find anything related in geopandas issues.

Investigation and potential solutions

For shapely >= 1.8, it seems that the correct usage would be using except GeometryTypeError (to verify), but this is problematic in terms of requirements:

shapely is not a direct requirement of snkit (and shouldn't be)
snkit requires geopandas>=0.10, which requires shapely>=1.6
even geopandas dev version still requires shapely>=1.7, not yet shapely>=1.8

The current solution is to catch the warning:

import warnings
from shapely.errors import ShapelyDeprecationWarning

with warnings.catch_warnings():
    warnings.filterwarnings('ignore', category=ShapelyDeprecationWarning)
    # ...

Conclusions

The problem would be solved upstream when geopandas increments the shapely requirements. But even so, I don't think it is worth a higher geopandas requirements, e.g. geopandas >=0.12.

What are the possibilities?

A temporary solution could be to catch the warning as above within snkit, but this would have the ironical consequence to make shapely a direct dependency by importing ShapelyDeprecationWarning
A simple comment in the code signaling the future error for shapely 2.0?
Nothing. This is left to the user.

tomalrussell / snkit