search

tomarrell / lbadd

LBADD: An experimental, distributed SQL database
MIT License
387 stars 26 forks source link

all: mark tests that can run in parallel as such #185

Closed tsatke closed 4 years ago

tsatke commented 4 years ago

Is your feature request related to a problem? Please describe. Tests apparently run slow on some machines/configurations.

Describe the solution you'd like Investigate whether there is significant performance improvements in the test speed when marking tests as parallel. Only tests that can run in parallel should be marked as such. No tests should be changed because of this ticket.

Describe alternatives you've considered No alternative, since we don't want to optimize code yet.

Additional context @TomArrell please confirm

tsatke commented 4 years ago

Closing this, because I don't see a need for that. Cold run on a MBP 2k17 go test -race ./... 20.46s user 4.79s system 340% cpu 7.419 total and with cache go test -race ./... 2.24s user 1.53s system 493% cpu 0.764 total which makes it even feasible using watchexec together with the race detector.

Cold without race detector: go test ./... 14.62s user 3.85s system 488% cpu 3.777 total Warm without: go test ./... 2.06s user 1.50s system 465% cpu 0.767 total

I don't even know if the difference for a warm test is significant. 0.2s for 1340 tests. I don't see how making parallel test runs would be beneficial at this point. Also, potentially long running tests are skipped when running tests in short mode, so if the tests are too slow, run with the -short flag.