tomarrell / lbadd

LBADD: An experimental, distributed SQL database
MIT License
387 stars 26 forks source link

engine: page defragmentation #202

Closed ayzu closed 4 years ago

ayzu commented 4 years ago

Implement a benchmark for page defragmentation operation (part of #183)

SUMUKHA-PK commented 4 years ago

Hey thanks for the PR!

Im not sure about the addition of use of the PR but we dont allow panics in the code - please ensure the CI passes :D

SUMUKHA-PK commented 4 years ago

Join can check out of one of the pinned issues to join our slack too!

ayzu commented 4 years ago

Hey thanks for the PR!

Im not sure about the addition of use of the PR but we dont allow panics in the code - please ensure the CI passes :D

Hey! That's was fast - you replied even before the CI finished :)

Thanks, fixed

ayzu commented 4 years ago

Join can check out of one of the pinned issues to join our slack too!

sorry, not sure that I got it. I joined the slack, btw

SUMUKHA-PK commented 4 years ago

Haha yes our slack bot notified me.

@TimSatke is actually the code owner for this part, it'll be reviewed by him :D

tsatke commented 4 years ago

Closing this as defragmentation will disappear. Page is defragmented upon delete, not when someone calls it.