tomas / needle

Nimble, streamable HTTP client for Node.js. With proxy, iconv, cookie, deflate & multipart support.
https://www.npmjs.com/package/needle
MIT License
1.63k stars 236 forks source link

Test failures on node v4-v12 #397

Closed joeyparrish closed 2 years ago

joeyparrish commented 2 years ago

PR #392 introduced failures in node v4-v12:


  1) socket reuse
       when sockets are reused
         does not duplicate listeners on .end:
     Uncaught Error: Unexpected error: Error: socket hang up
      at /Users/alcatrazqa/joey/needle/test/socket_pool_spec.js:42:19
      at done (lib/needle.js:501:14)
      at ClientRequest.had_error (lib/needle.js:516:5)
      at Socket.socketCloseListener (_http_client.js:401:11)
      at TCP.<anonymous> (net.js:675:12)

  2) socket reuse
       "after all" hook:
     Uncaught Error: Unexpected error: Error: socket hang up
      at /Users/alcatrazqa/joey/needle/test/socket_pool_spec.js:42:19
      at done (lib/needle.js:501:14)
      at ClientRequest.had_error (lib/needle.js:516:5)
      at Socket.socketCloseListener (_http_client.js:401:11)
      at TCP.<anonymous> (net.js:675:12)

  3) stream events
       "before all" hook:
     Uncaught Error: Unexpected error: Error: connect ECONNREFUSED 127.0.0.1:11112
      at /Users/alcatrazqa/joey/needle/test/socket_pool_spec.js:42:19
      at done (lib/needle.js:501:14)
      at ClientRequest.had_error (lib/needle.js:516:5)
      at Socket.socketErrorListener (_http_client.js:427:9)
      at emitErrorNT (internal/streams/destroy.js:92:8)
      at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
      at processTicksAndRejections (internal/process/task_queues.js:84:21)

  4) uri_modifier config parameter function
       "before all" hook:
     Uncaught Error: listen EADDRINUSE: address already in use :::3456
      at Server.setupListenHandle [as _listen2] (net.js:1316:16)
      at listenInCluster (net.js:1364:12)
      at Server.listen (net.js:1450:7)
      at Object.helpers.server (test/helpers.js:70:10)
      at Context.<anonymous> (test/uri_modifier_spec.js:18:22)
      at processImmediate (internal/timers.js:461:21)

  5) uri_modifier config parameter function
       "after all" hook:
     Error [ERR_SERVER_NOT_RUNNING]: Server is not running.
      at Server.close (net.js:1604:12)
      at emitCloseNT (net.js:1657:8)
      at processTicksAndRejections (internal/process/task_queues.js:83:21)
      at runNextTicks (internal/process/task_queues.js:66:3)
      at processImmediate (internal/timers.js:434:9)

  6) urls
       "before all" hook:
     Uncaught Error: listen EADDRINUSE: address already in use :::3456
      at Server.setupListenHandle [as _listen2] (net.js:1316:16)
      at listenInCluster (net.js:1364:12)
      at Server.listen (net.js:1450:7)
      at Object.helpers.server (test/helpers.js:70:10)
      at Context.<anonymous> (test/url_spec.js:18:22)
      at processImmediate (internal/timers.js:461:21)

  7) stream events
       when consuming data directly
         and request succeeds but decoding fails
           emits done event without error:
     TypeError: Cannot read property 'call' of undefined
      at processImmediate (internal/timers.js:461:21)

  8) stream events
       when consuming data directly
         and request succeeds and pipeline works ok
           emits done event without error:
     Uncaught Error: Unexpected error: Error: connect ECONNREFUSED 127.0.0.1:11112
      at /Users/alcatrazqa/joey/needle/test/socket_pool_spec.js:42:19
      at done (lib/needle.js:501:14)
      at ClientRequest.had_error (lib/needle.js:516:5)
      at Socket.socketErrorListener (_http_client.js:427:9)
      at emitErrorNT (internal/streams/destroy.js:92:8)
      at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
      at processTicksAndRejections (internal/process/task_queues.js:84:21)

  9) stream events
       Uncaught error outside test suite:
     Uncaught Error: Unexpected error: Error: connect ECONNREFUSED 127.0.0.1:11112
      at /Users/alcatrazqa/joey/needle/test/socket_pool_spec.js:42:19
      at done (lib/needle.js:501:14)
      at ClientRequest.had_error (lib/needle.js:516:5)
      at Socket.socketErrorListener (_http_client.js:427:9)
      at emitErrorNT (internal/streams/destroy.js:92:8)
      at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
      at processTicksAndRejections (internal/process/task_queues.js:84:21)