tomas / needle

Nimble, streamable HTTP client for Node.js. With proxy, iconv, cookie, deflate & multipart support.
https://www.npmjs.com/package/needle
MIT License
1.63k stars 236 forks source link

Bug in 3.3.0: accidental creation of `global.signal`, gets caught in strict UTs #429

Closed oliverlockwood closed 11 months ago

oliverlockwood commented 11 months ago

Reproduction scenario:

Investigation and debugging proved the issue was a rogue semicolon that should have been a colon. Perhaps an argument in favour of separate var declarations instead of a block of them? In any case, it's a 1-character fix, which I will raise as a PR very shortly.

This bug was not in Needle 3.2.0.