search

tomasAlabes / graphql-kafkajs-subscriptions

Apollo graphql subscriptions using kafkajs
MIT License
24 stars 6 forks source link

kafkajs version #20

Closed vertho closed 2 years ago

vertho commented 2 years ago

Hi. Could you please upgrade kafkajs to latest version? I've tested this locally after cloning the repo and 2.1.0 seems to work fine. version 2.1.0 of kafkajs seems to be much more stable

nanopils commented 2 years ago

Hi.

We need this as well. Could you please take a look at this?

Kind Regards,

Nils

tomasAlabes commented 2 years ago

i will try this week, PRs are also welcome :)

------- Original Message ------- On Monday, August 15th, 2022 at 9:44 AM, nanopils @.***> wrote:

Hi.

We need this as well. Could you please take a look at this?

Kind Regards,

Nils

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

vertho commented 2 years ago

i will try this week, PRs are also welcome :) … ------- Original Message ------- On Monday, August 15th, 2022 at 9:44 AM, nanopils @.> wrote: Hi. We need this as well. Could you please take a look at this? Kind Regards, Nils — Reply to this email directly, [view it on GitHub](#20 (comment)), or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.>

I tried but I don't have access to push code or branches

tomasAlabes commented 2 years ago

Could you try graphql-kafkajs-subscriptions@3.0.0-0 and let me know how it goes? If it works I will release the final 3.0.0

@vertho you don't need permissions in my repo to contribute, check out this docs to see contributions work in github 😉

vertho commented 2 years ago

@tomasAlabes thanks for the link. I'll be sure to submit a PR for you next time. I just pulled your 3.0.0 version and ran it up with yalc. Everything looks good on my end

tomasAlabes commented 2 years ago

Merged 3.0.0