search

tomasbasham / ember-cli-analytics

An ember-cli addon to interface with analytics services and external integrations
MIT License
8 stars 9 forks source link

Adding options for incorporating analytics scripts into the build #12

Closed psbanka closed 6 years ago

psbanka commented 6 years ago

Currently ember-cli-analytics will always attempt to download analytics scripts from their origins and will fail if those sites are blocked with a content-security-policy. However, it is possible to incorporate those scripts using the build process and not to need a hole punched in the CSP for this activity. Some higher-security sites might prefer this option.

This PR allows for this avenue to be used.

psbanka commented 6 years ago

CodeClimate doesn't like this if structure codeclimate

So I opted for this structure instead, does that work? early-return

tomasbasham commented 6 years ago

Ah I see. That is fine. In fact I prefer the returning early approach 👍 I'm going to merge this now