tomasbasham / ember-cli-analytics

An ember-cli addon to interface with analytics services and external integrations
MIT License
8 stars 9 forks source link

Add error handling adwords #7

Closed its-schmii closed 1 year ago

its-schmii commented 7 years ago

The adwords adapter currently throws an error if used with firefox & tracking protection. I enclosed the call to adwords with try catch to make sure no javascript error is thrown.

its-schmii commented 7 years ago

Can sb. explain to me why the checks failed? due to some duplicate code that was already there to begin with?

its-schmii commented 7 years ago

The conflict I resolved