search

tomasbasham / ember-cli-scss-lint

An ember-cli addon to integrate sass-lint for standards adherence and improved style consistency
MIT License
7 stars 6 forks source link

Do not return original tree when not linting. #12

Closed rwjblue closed 7 years ago

rwjblue commented 7 years ago

The lintTree hook is expected to only return a value when it is emitting contents that are different than the input tree (e.g. it emits lint tests). Returning the original input tree results in extra wasted processing (double modules transpilation, extra build work to merge, etc).

FWIW, returning the original raw tree is causing errors in ember-cli@2.13.0 (should be fixed in 2.13.1) see https://github.com/ember-cli/ember-cli/pull/7036.

tomasbasham commented 7 years ago

That great, man. Thanks