Open mehulkar opened 6 years ago
This sounds like a good idea
We ended up going with sytlelint and the associated ember addon by @billybonks: https://github.com/billybonks/ember-cli-stylelint
It would still be great to pare all of these down to a single addon that is included in the ember-cli default blueprint (or maybe the linter could be included in the ember-cli-sass
addon @aexmachina?)
I'm not sure what the best approach forward is, but happy to have a conversation.
@mehulkar my preference would be to keep ember-cli-sass minimal. People can add linters if they so choose.
regarding ember-cli-stylelint vs ember-cli-sass. i think not all rules are available in stylelint addons yet
I'm open to merging the projects. One of the original reasons for creating ember-cli-sass-lint
was to have a style linting solution with JS-only dependencies (e.g. no requirement for a sass gem or global deps). Since ember-cli-sass-lint
and ember-cli-scss-lint
now both fallback to sass-lint
, there isn't much benefit to both projects existing independently.
To @mehulkar's last point, I'm not sure if a style linter is demanded enough to be included in the ember-cli blueprint. Would be happy to be proven wrong though!
@tomasbasham Are you interested in continuing to maintain the project?
This project looks very similar to https://github.com/sir-dunxalot/ember-cli-sass-lint. Could they be merged? Looks like the all fallback to
sass-lint
, but through separate broccoli plugins.cc @artursmirnov @sir-dunxalot
Relevant links: