tomasbedrich / home-assistant-hikconnect

A Home Assistant integration to communicate with Hikvision smart doorbells via Hik-Connect cloud.
42 stars 10 forks source link

Add Hikvision logo #3

Closed pepsonEL closed 2 years ago

pepsonEL commented 3 years ago

Good feature (cosmetic) will be add logo HikVision to integration show in HACS and after install in Home Assistant. Now is blank.

tomasbedrich commented 3 years ago

Good idea. In progress: https://github.com/home-assistant/brands/pull/2847

tomasbedrich commented 3 years ago

I can see the logo now - closing. Please comment if it is not working for you.

pepsonEL commented 3 years ago

I still no see logo. Maybe new version should be release.

tomasbedrich commented 3 years ago

Try refresh without cache in your browser. CMD/CTRL + Shift + R.

pepsonEL commented 3 years ago

Still no see, i also cleat cache by F12 in chrome and nothing.... But probably to see logo i must install new integration which has logo ?

tomasbedrich commented 3 years ago

Strange.. It shouldn't require a new installation (this is how it worked on my side). It only requests the logo from here: https://brands.home-assistant.io/hikconnect/icon.png Maybe just give it some time.

pepsonEL commented 3 years ago

this link no workin nopage g

tomasbedrich commented 3 years ago

I trust you but it is working on my side. :) Just wait some time and it hopefully deletes itself from all the caches in between. :)

pepsonEL commented 3 years ago

I also try on other web browser and the same issue.

pepsonEL commented 3 years ago

Still no show logo. In my opinion something is wrong.

pepsonEL commented 3 years ago

In installed integration still no see logo look: logo

But in list integration to install i see logo: list

pepsonEL commented 2 years ago

please reopen it.

tomasbedrich commented 2 years ago

Hi @pepsonEL, I hear you with the logo issue. I still think we should wait (there is a max-age of 604800sec = 7d) / someone else should verify it.

Maybe if you can test it using curl from your PC? Can you please try following and put here the output?

curl --head https://brands.home-assistant.io/hikconnect/icon.png
curl --head https://brands.home-assistant.io/hikconnect/icon@2x.png
curl --head https://brands.home-assistant.io/hikconnect/logo.png
curl --head https://brands.home-assistant.io/hikconnect/logo@2x.png
pepsonEL commented 2 years ago

I dont have linux. I use Windows. But when i try open all this link: https://brands.home-assistant.io/hikconnect/icon.png https://brands.home-assistant.io/hikconnect/icon@2x.png https://brands.home-assistant.io/hikconnect/logo.png https://brands.home-assistant.io/hikconnect/logo@2x.png

all works and i see logos in this images.

tomasbedrich commented 2 years ago

There is some contradiction. Previously you written that the link is not working (not even in another browser). Today you wrote that all links are working. So is there some progress or not?

If yes, I think we should not continue with debugging, because it only takes time and we have a good chance that it fixes itself.

pepsonEL commented 2 years ago

Previously i test it in home. Yesterday i try this link in my work. Logo is still unavailable. Please share screenshot where you show that you have logo in configuration>integration after install.

pepsonEL commented 2 years ago

Sorry now i test again and only one link no working correct: https://brands.home-assistant.io/hikconnect/icon.png No show image and show this: 135410930-2831b7cf-7c68-4594-8e55-77b56e36dde5

This links works ok and show image. https://brands.home-assistant.io/hikconnect/icon@2x.png https://brands.home-assistant.io/hikconnect/logo.png https://brands.home-assistant.io/hikconnect/logo@2x.png

tomasbedrich commented 2 years ago

screenshot 2021-10-05 at 11 34 15

Here is the screenshot including Sources panel, also here is the dump from Chrome Network panel:

Request URL: https://brands.home-assistant.io/hikconnect/icon.png
Request Method: GET
Status Code: 200 
Remote Address: 172.67.68.90:443
Referrer Policy: no-referrer
accept-ranges: bytes
age: 474990
alt-svc: h3=":443"; ma=86400, h3-29=":443"; ma=86400, h3-28=":443"; ma=86400, h3-27=":443"; ma=86400
cache-control: public,max-age: 900,s-maxage=604800,must-revalidate
cf-bgj: imgq:100,h2pri
cf-cache-status: HIT
cf-polished: status=not_needed
cf-ray: 6995a8de3fac412c-PRG
content-length: 10728
content-type: image/png
date: Tue, 05 Oct 2021 09:35:23 GMT
etag: "540f1b86d0c0e914f64ee89c8b272b3a-ssl"
expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
nel: {"success_fraction":0,"report_to":"cf-nel","max_age":604800}
report-to: {"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v3?s=XAtPAe9W3mtcNRQnUDpo%2FdHPZUwGKxxFSRPt4JQERUwwT6HrOdBqhe1KXVyPS9qiNMBvTwSYv9g3OZ2D0rCzcKexUHdJNxeQV0nNE5%2BbMQFPzkPC89szbcSLgxrCy0CcBz4fVcaYUwwk%2FQ%3D%3D"}],"group":"cf-nel","max_age":604800}
server: cloudflare
vary: Accept-Encoding
x-nf-request-id: 01FGSQXZBT10VCKWDWXSWHZGB7

As you can see, there is cache-control: public,max-age: 900,s-maxage=604800,must-revalidate, so I guess it may stick for 604800 seconds with poisioned cache (by HTTP response 404 - non-existing image).

If you want me to debug from your point of view, please send me HAR file generated by loading your /config/integrations page.

pepsonEL commented 2 years ago

This is my: look visibility: Hidde logos n

pepsonEL commented 2 years ago

Ok now logo start visible . Now is OK. I dont do anything.

tomasbedrich commented 2 years ago

See it's probably 7 days from your first usage of the integration (according to the issue comment datetime). :)

pepsonEL commented 2 years ago

:)

pepsonEL commented 2 years ago

now good point will be issue #4 and #6