tomasbedrich / home-assistant-hikconnect

A Home Assistant integration to communicate with Hikvision smart doorbells via Hik-Connect cloud.
40 stars 9 forks source link

Don't report camera-only devices as locks #7

Closed tomasbedrich closed 2 years ago

tomasbedrich commented 2 years ago

(Splitting issue #2 on behalf of @pepsonEL)

In app HikConnect i also has added my NVR with 7 cameras and now i see it in Home Assistant as entity lock.xxxxxxxx Why and what it is ?

Quoting https://community.home-assistant.io/t/hik-connect/342202/5?u=tomasbedrich:

... the integration is based on assumption, that all devices connected to Hik-Connect has both lock + camera function available. This seems to be wrong assumption (based on your example) and we must fix it somehow.

tomasbedrich commented 2 years ago

Hi @pepsonEL, I created a new version f5ce468466e49c1dbdbef0c4ca045381797fb516. Despite I was focusing on fixing this issue, I guess it may fix also #2. Can you please give it a try? Please, uninstall the old version first, then update using HACS, reinstall and restart Home Assistant. Then you can enable the integration again. Please send me your logs again to ja@tbedrich.cz if it doesn't work. Thanks.

pepsonEL commented 2 years ago

On this new version no found me any entieies after install new version. On email i send logs...

tomasbedrich commented 2 years ago

Thank you, it helped me to read your logs! There was a minor glitch that I expected all devices to report connected locks. It should be fixed in 1132902d969209f4fe2e7ee2cb5949e07faf51b4. Can you try it please? Complete reinstall of integration is probably needed again.

pepsonEL commented 2 years ago

Ok i try. But please also see issue closed with problem logo....

pepsonEL commented 2 years ago

I test new version and now all works ok. Integration found me only 2device/2entity and it is 1 door and 2 door. And now when i create script open door works also for 1 and 2 door. Very good. Any cameras not found for me. I send you on email logs. 1

tomasbedrich commented 2 years ago

Good, I am closing this issue then + #2 too.

pepsonEL commented 2 years ago

Thanks good job. Now good will be add to also recognized camera from video intercom and status when idle when ring.