search

tomasbjerre / pull-request-notifier-for-bitbucket

Bitbucket Server plugin that invokes a custom URL when a pull request event is triggered.
Other
185 stars 74 forks source link

Pull Request Notifier for Bitbucket plugin: Warnings should be shown in the plugin page instead of being thrown into the general BBS log. #203

Open CHD-CM-Support-Users opened 7 years ago

CHD-CM-Support-Users commented 7 years ago

From: Sedlock, David Sent: Wednesday, 22 February, 2017 15:45 To: Tomas Bjerre tomas.bjerre85@gmail.com Subject: pull-request-notifier-for-bitbucket - exception reporting Hi Tomas, Exceptions are now going into the BBS logs, to which users don't have access. How about if your plugin catches its own exceptions and makes them available in a log section of the existing pages? It would be nice if they were segregated by project and repo, so that the repo level log would show exceptions only for the repo, the project level log would show exceptions only for the project and the global page would show all exceptions. The logs/s could be purged every few days. What do you think? Regards, David ----Original Message---- From: Sedlock, David Sent: Tuesday, 21 February, 2017 16:05 To: DL-LQ-ADM-HG DL-LQ-ADM-HG@intel.com Subject: Munin notification for Bitbucket Prod (mucrsz0011.muc.lantiq.com) server Tue Feb 21 16:05:19 CET 2017 localhost :: localhost :: bitbucket log monitor WARNINGs: _home_admgts_bitbucket-prod_data_log_atlassian-bitbucket_log is 1.00 (outside range [:0.9]): 2017-02-21 16:04:47,415 ERROR [threadpool:thread-3] rennerma @O3P696x964x92356x27 125gffx 10.252.33.7,127.0.0.1 "PUT /rest/api/latest/projects/SW_PON/repos/pon_lib/pull-requests/43/participants/rennerma HTTP/1.1" se.bjurr.prnfb.http.UrlInvoker---------.

tomasbjerre commented 7 years ago

There is information about the response from the notified system: https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/blob/master/src/main/java/se/bjurr/prnfb/presentation/dto/ButtonPressDTO.java#L14

And if its not the response causing the problem then its likely a bug in this plugin and should be reported as such.

I would need examples of such exceptions.

CHD-CM-Support-Users commented 7 years ago

That's fine! But if the user of the plugin sees the warnings, there is no need to add them to the BBS log. There is no actionable information there for the BBS admin. It would be better to reserve such warnings for bugs, not usage problems.