search

tomasbjerre / violation-comments-to-gitlab-maven-plugin

A plugin for Maven that will find report files from static code analysis and comment merge requests in GItLab with them. Edit Add topics Edit Add topics
Other
4 stars 4 forks source link

Update pom.xml #10

Open ateglas opened 1 year ago

ateglas commented 1 year ago

Would it be possible to update the dependencies for the maven plugin so that it requests for the latest versions of violation-comments-lib and violation-lib? The gradle plugin for example requires a range, anything 1.+

Basically, replace:

    <properties>
        <violation-comments-lib>1.86.4</violation-comments-lib>
        <violations-lib>1.148.3</violations-lib>
    </properties>

with either 

    <properties>
        <violation-comments-lib>[1.86.4,)</violation-comments-lib>
        <violations-lib>[1.148.3,)</violations-lib>
    </properties>

or just with latest version hardcoded

    <properties>
        <violation-comments-lib>1.87.0</violation-comments-lib>
        <violations-lib>1.156.3</violations-lib>
    </properties>
tomasbjerre commented 1 year ago

I think most people want controlled upgrade. Is there any way of locking the version after this change?

ateglas commented 1 year ago

One of the ways to do it, which works for both upgrading and downgrading, would be to overwrite the versions for the dependent libraries. It is just that now, gradle plugin users get, by default, the latest bugfixes and the latest parsers, while maven plugin users get, by default, just the parsers that were available in the included versions. 

            <plugin>
              <groupId>se.bjurr.violations</groupId>
              <artifactId>violation-comments-to-gitlab-maven-plugin</artifactId>
              <version>1.47.0</version>
              <dependencies>
                <dependency>
                  <groupId>se.bjurr.violations</groupId>
                  <artifactId>violation-comments-to-gitlab-lib</artifactId>
                  <version>1.87.0</version>
                </dependency>
                <dependency>
                  <groupId>se.bjurr.violations</groupId>
                  <artifactId>violations-lib</artifactId>
                  <version>1.156.3</version>
                </dependency>
              </dependencies>
              ...
            </plugin>
vishalsingh2972 commented 1 year ago

@tomasbjerre @ateglas can you please review PR https://github.com/tomasbjerre/violation-comments-to-gitlab-maven-plugin/pull/11