search

tomasbjerre / violations-lib

Java library for parsing report files from static code analysis.
Apache License 2.0
148 stars 39 forks source link

`CodeClimateParser` should map `engine_name` to `reporter` #133

Closed remal closed 3 years ago

remal commented 3 years ago

CodeClimate class has engine_name field that is supposed to handle a tool name that generated the violation: https://github.com/tomasbjerre/violations-lib/blob/f24f5293544ae9f9886de267140819d3e9cb0884/src/main/java/se/bjurr/violations/lib/model/codeclimate/CodeClimate.java#L20

However, CodeClimateParser doesn't handle engine_name field at all and just sets CODECLIMATE string as a tool name: https://github.com/tomasbjerre/violations-lib/blob/f24f5293544ae9f9886de267140819d3e9cb0884/src/main/java/se/bjurr/violations/lib/parsers/CodeClimateParser.java#L48-L56

Could you please add engine_name to reporter mapping?

tomasbjerre commented 3 years ago

fixed, open issue again if any problems.