search

tomasbjerre / violations-lib

Java library for parsing report files from static code analysis.
Apache License 2.0
148 stars 39 forks source link

Use OWASP Java Encoder #151

Open jeremylong opened 2 years ago

jeremylong commented 2 years ago

The OWASP Java Encoder is a high performance encoding library. While I understand this is adding a dependency - the encoder project itself has not dependencies and is a very stable library.

tomasbjerre commented 2 years ago

If the tripple brackets solves this, the PR can be closed: https://github.com/tomasbjerre/violation-comments-lib/pull/22#issuecomment-1133535735

Or else, I think this library needs to be relocated in the build.gradle:

project.ext.buildConfig = [
  publishing: [
    relocate: [
      'com.google',
      'com.jakewharton',
      'org.owasp'
    ]
  ],
jeremylong commented 2 years ago

Thank you for pointing out the triple bracket syntax. Yes, that solves my current issue. However, this PR was not specifically to fix the newline issue I was having. While yes, it does introduce a new library - the library is faster, compliant with the RFC, and does not have any transitive dependencies. But I also understand the desire to use fewer libraries. Totally fine if you don't want to introduce a dependency.