tomasc / dragonfly_svg

Dragonfly SVG plugin.
MIT License
4 stars 3 forks source link

switch from Nokogiri to Ox #2

Open tomasc opened 9 years ago

tvdeyen commented 8 years ago

I don't think this is a good idea. Rails has Nokogiri as dependency, so everybody requiring you're plugin in a rails app would then have two XML parsers in their app.

tomasc commented 8 years ago

Well … Nokogiri is a bit difficult because of its use of C library, and I would not rely on Rails having it as a dependency forever. We're using Ox elsewhere and it's just fine.

tvdeyen commented 8 years ago

I know. What about making a check if Nokogiri is defined, and require ox only if not.

tomasc commented 8 years ago

This is not urgent. We can keep this as is, and only eventually replace Nokogiri with something more lightweight.