Feature/add drop entity overloads to ksqldbrestapiclient

tomasfabian / ksqlDB.RestApi.Client-DotNet

ksqlDb.RestApi.Client is a C# LINQ-enabled client API for issuing and consuming ksqlDB push and pull queries and executing statements.

MIT License

93 stars 24 forks source link

Feature/add drop entity overloads to ksqldbrestapiclient #62

Closed tomasfabian closed 3 months ago

tomasfabian commented 3 months ago

introduced new overloads for dropping entities: DropTableAsync, DropTypeAsync, and DropStreamAsync in KSqlDbRestApiClient. These overloads now accept an argument DropFromItemProperties, providing more flexibility in configuring the drop operations.
extracted IKSqlDbDropRestApiClient interface from IKSqlDbRestApiClient

tomasfabian commented 3 months ago

Hi @mrt181, could you review this PR, please? It adds identifier escaping for DROP statements.

mrt181 commented 3 months ago

Hi @mrt181, could you review this PR, please? It adds identifier escaping for DROP statements.

I added a few comments

tomasfabian commented 3 months ago

I added a few comments

Did you submit the comments? I can't find them.

mrt181 commented 3 months ago

I added a few comments

Did you submit the comments? I can't find them.

Yes, sorry, forgot to submit

tomasfabian commented 3 months ago

@mrt181 thank you for the review so far! I published a prerelease version 4.0.0-rc.1 of ksqlDb.RestApi.Client. Feel free to inform me if there are any other areas we can enhance or improve upon.