search

tomasfarias / airflow-dbt-python

A collection of Airflow operators, hooks, and utilities to elevate dbt to a first-class citizen of Airflow.
https://airflow-dbt-python.readthedocs.io
MIT License
170 stars 35 forks source link

fix: Check for tasks without a profile without UnsetProfileConfig #118

Closed tomasfarias closed 9 months ago

tomasfarias commented 1 year ago

Fixes #117

dbt actually got rid of UnsetProfileConfig (see: https://github.com/dbt-labs/dbt-core/commit/5b31cc4266e8dd5d2e5e94755343baf72dd866a0). So we shouldn't rely on it anymore. Instead, we can just check we are not running a Task that doesn't use a profile (deps or clean).

Hopefully this is all required to support dbt-core 1.5.

tomasfarias commented 1 year ago

Tests are green with dbt-core 1.4.5. I'll push a lock file update together with the package version bump to test out dbt-core 1.5 too.

tomasfarias commented 1 year ago

Unfortunately, UnsetProfileConfig wasn't the only thing removed in dbt-core 1.5: apparently ParseTask is no more, and a lot of setup functions changed their signature. I'm pushing some changes to maintain backwards compatibility as I do not wish to drop support for dbt 1.4 just yet. However, these changes will require testing, so it's likely this fix will not be as quick as expected. In the meantime, stick to dbt-core==1.4.5.

We don't have a policy on dbt supported versions, so as long as it's not much of a hassle, I'll try to support all dbt-core>=1.0.0 versions.

tomasfarias commented 9 months ago

Closed in favor of #127