search

tomaskenis / cjwizard

Somehting to use for git svn tag conversion
0 stars 0 forks source link

Dependency on Apache Commons Logging #3

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
cjwizard depends on org.apache.commons.logging.LogFactory which is pretty bad 
for a wizard library which could otherwise be used in a variety of projects not 
using apache commons logging.

Thus, logging should be dropped (it’s debug only anyway) or made optional.

Original issue reported on code.google.com by Kissa...@gmail.com on 16 Nov 2010 at 11:01

GoogleCodeExporter commented 9 years ago 
Here's a patch to replace commons-logging with slf4j.

This change would also require dropping commons-logging-1.1.1.jar and adding 
slf4j-api-1.6.1.jar and slf4j-log4j12-1.6.1.jar (alternatively you could use 
the slf4j-simple-1.6.1.jar (which just writes to stdout) and remove log4j from 
the project).

Sorry, could not figure out how to ignore the whitespace, either with eclipse 
or tortoise.

Original comment by nathan.d...@gmail.com on 27 Apr 2011 at 5:21

Attachments:

GoogleCodeExporter commented 9 years ago 
If you wanna remove external dependencies why not use the 
[http://docs.oracle.com/javase/6/docs/technotes/guides/logging/ Java Loggin 
API]?

Original comment by PhoneixS...@gmail.com on 18 Apr 2013 at 10:59

GoogleCodeExporter commented 9 years ago 
Here is a patch to remove log4j and replace it with native java logging. Get in 
mind that I have not translate the log4j formats to JUL but if you think in 
adding this to the trunk I can make it.

Original comment by PhoneixS...@gmail.com on 2 Oct 2013 at 7:31

Attachments:

GoogleCodeExporter commented 9 years ago 
"removing external dependencies" is not the point. the point is making your 
wizard a well-behaved component that application developers can drop in without 
causing difficulties. As a component developer you don't get to choose the 
logging framework, that's up to the application developer. You should use 
something like slf4j so that your component will use whatever logging framework 
the application it's added to uses.

Original comment by nathan.d...@gmail.com on 28 Dec 2013 at 6:23

GoogleCodeExporter commented 9 years ago 
Moved to github:

https://github.com/creswick/cjwizard/issues/3

Original comment by cresw...@gmail.com on 28 Mar 2014 at 10:05