tomasklaen / uosc

Feature-rich minimalist proximity-based UI for MPV player.
GNU Lesser General Public License v2.1
1.5k stars 63 forks source link

Error during usage: shared-script-properties property is deprecated #883

Closed boredness closed 2 months ago

boredness commented 2 months ago

I'm getting this error during usage when pressing any of the menu buttons:

Resuming playback. This behavior can be disabled with --no-resume-playback.
 (+) Video --vid=1 (*) (h264 1920x800 23.976fps)
 (+) Audio --aid=1 --alang=eng (*) 'DTS 6Ch 1510 Kbps' (dts 6ch 48000Hz)
     Audio --aid=2 --alang=eng 'Commentary by Tim Robbins and Kevin Bacon - AC-3 2Ch 192 Kbps' (ac3 2ch 48000Hz)
     Subs  --sid=1 --slang=eng (subrip)
     Subs  --sid=2 --slang=eng 'English SDH' (subrip)
     Subs  --sid=3 --slang=dut (subrip)
     Subs  --sid=4 --slang=fre (subrip)
     Subs  --sid=5 --slang=ger (subrip)
     Subs  --sid=6 --slang=nor (subrip)
     Subs  --sid=7 --slang=rus (subrip)
     Subs  --sid=8 --slang=spa (subrip)
AO: [pipewire] 48000Hz 5.1(side) 6ch floatp
VO: [gpu-next] 1920x800 yuv420p
The shared-script-properties property is deprecated and will be removed in the future. Use the user-data property instead.
Saving state.
Exiting... (Quit)

Here is the output from a log.txt

[   9.542][d][cplayer] Run command: change-list, flags=64, args=[name="shared-script-properties", operation="append", value="uosc-menu-type=sub"]
[   9.542][w][cplayer] The shared-script-properties property is deprecated and will be removed in the future. Use the user-data property instead.

Setup:

mpv --version                                                                                                                                            
mpv v0.37.0 Copyright © 2000-2023 mpv/MPlayer/mplayer2 projects

uosc version 5.2.0
christoph-heinrich commented 2 months ago

Thanks for reporting, but that has already been taken care of.

shared-script-properties are still being written to for compatibility with scripts that rely on them, but we also check for their availability, so their removal won't break uosc :)