search

tomasklaen / uosc

Feature-rich minimalist proximity-based UI for MPV player.
GNU Lesser General Public License v2.1
1.51k stars 61 forks source link

Can binding such as `Ctrl + Enter` for confirming searches be customized? #915

Open Kabouik opened 4 weeks ago

Kabouik commented 4 weeks ago

I use mpv/uosc through ssh and taking advantage of mpv --terminal-input, but it seems this fails to convey keybinds such as Ctrl + Enter. This is a shame because I'd need it to confirm search for the download_subs feature (a wonderful addition by the way; I'll soon reach the limit when binging episodes, but might be able to reset it using a proxy I guess).

I really love the new uosc. So many QOL additions since the old version I was using so far (download_subtitles, keybinds, etc.).

tomasklaen commented 4 weeks ago

No, these are not configurable. We use alt, shift, and ctrl each for something else, so there's not much else to configure it to. Also, you'd be the only person on the planet using it, and I don't like adding options with such low relevance.

But the inability to send some shortcuts sounds like a bug/issue with your environment, so I'd try to solve it there.

If anything is going to happen regarding this on uosc's side, I'd probably just want to eliminate ctrl+enter binding completely, and replace it with only enter that is aware of what is focused atm (input or item).

Kabouik commented 3 weeks ago

Thanks! I don't think my environment is the cause, it seems that those bindings with modifier are not properly conveyed by mpv --terminal-input, even locally, and using mpv through ssh just makes me rely on terminal input.

It would be convenient if uosc could be entirely manipulated with the limited list of bindings that c[an work with terminal input, but I understand it's not really a uosclimitation in the first place. I may not know exactly what motivates the use of a modifier for confirming searches but if I understand correctly your message, that may be because uosc may not know what is currently focused.

Some keys with Ctrl are properly conveyed though, like Ctrl+u which I set to update uosc. If Ctrl+Enter works on your end while focusing the terminal holding the mpv process, then I guess something is indeed intercepting that key in my environment (I'm sorry if that's the case).