search

tomasko126 / easylistczechandslovak

EasyList Czech and Slovak is an official filter list for uBlock Origin, AdBlock, Adblock Plus and other ad blockers out there.
https://adblock.sk
Creative Commons Attribution Share Alike 4.0 International
100 stars 60 forks source link

Recent change seems to have broken krimi-plzen.cz filters in uBlock #319

Closed staticf0x closed 3 years ago

staticf0x commented 3 years ago

I'm sorry for the issue title, not sure how to best describe this. This commit (bee2bd0) seems to have broken the filters on krimi-plzen.cz. Instead of having specific filters for all the div classes to block, there's now a wildcard filter. For some reason, it doesn't work, when it comes from this list, but it works, when I copy that filter into My filters. Is there any reason for uBlock to work like that?

uBlock version: 1.35.2

addisr commented 3 years ago

Have you changed the rules before putting them into My filters? They updated their class names so rule krimi-plzen.cz##[class*="partner"] no longer works.

staticf0x commented 3 years ago

Found the issue, from the PR description:

The issue is that the actual class used on the site contains \x0d\x0b instead of the ascii a. Not sure if it's a typo or if it was intentional, but it was a fun bug to investigate.

:smile:

staticf0x commented 3 years ago

To add to this: it explains why it works when copying the selector from uBlock's popup and not writing it manually.