search

tomasmcguinness / pkpassvalidator

Checks the validity of a PKPASS file by checking it's signature and contents match the Apple specification
MIT License
78 stars 21 forks source link

Ticket passed validation but cannot open #2

Open DerekFangming opened 6 years ago

DerekFangming commented 6 years ago

Hi, Thanks for the tool. I have code to generate pass and it had been working for a year until last month when my pass certificate expired. I renewed it and now, my code still generates pass without problem, but I can no longer open it, on either my laptop or my phone. Here are the two files. The working.pkpass is generated on Feb this year and you can open it with wallet on laptop or phone. When I validate this, it shows the expired signature on your website, which is expected. The notWorking.pkpass was generated with renewed certificate. It passes all the validation but just won't open.

Do you know what could go wrong with the new ticket?

Thanks!

tomasmcguinness commented 6 years ago

Hello,

I'm happy to take a look, but I don't have permission to access that GDrive share. I have requested permission. I'll review again, once I have access to the passes.

Thanks!

Tom

tomasmcguinness commented 6 years ago

Hello - will you be able to provide me with permission?

DerekFangming commented 6 years ago

Oh hi, sorry for the late reply.

I have fixed it in the pass kit SDK here

If you want to read details, look at the conversation I had with the repo owner here

Basically, the pkpass file cannot have files in it with name starting with a dot. You can do your checkings in your code. However, I suggest you to integrate with apple's default pkpass signer to double check the tickets. It's a C project that can be compiled to executable.

Here's the new link for the not working pkpass for a kick start.

Feel free to close this issue

tomasmcguinness commented 6 years ago

Thank you! I'll review and add that check into the validator.