Closed tomasnorre closed 2 weeks ago
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Now a URL with MP is used:
Processing https://website.ddev.site:8443/en/?MP= () => OK:
This shouldn't be an issue, as the correct canonical is used (without MP), just a little bit unaesthetic.
@brotkrueml I know it's a long time ago, but do you recall how to reproduce this? I cannot get it reproduced.
Sorry, no. But if you can't reproduce it, maybe that is gone? :-)
Thanks for your feedback, didn't expect that to be honest either. I'll see if I cannot reproduce it in near future, I'll expect it to be solved until it gets reported again.
I'll close this issue for now, as all issues, that still needs to be address is addressed in a new issue.
From @brotkrueml comments in review: https://github.com/tomasnorre/crawler/pull/754#issuecomment-864586872
I have extracted the comments into separate issues, to ease the fixes and keep the PRs smaller.
Now a URL with MP is used:
This shouldn't be an issue, as the correct canonical is used (without MP), just a little bit unaesthetic.
Cannot reproduce this anymore. @tomasnorre
Running the command without
depth
:omits the detailled information from above for other pages. The
<br>
tag should be converted to a new line on console.Edit: I cannot reproduce this as of
crawler 12.4.0
@tomasnorreI am getting many empty lines when calling a
buildQueue
command withdepth
. Perhaps these empty lines come from "successful" pages without any output. I think, they should be avoided.Edit: Fixed as part of #1097 @tomasnorre