tomaspinho / rtl8821ce

Other
1.59k stars 409 forks source link

8821c sees mainline support in rtw88 #142

Open makson96 opened 4 years ago

makson96 commented 4 years ago

Hi, I just want to share with you great news, which I discovered. As of today initial support for rtl8821c was published for mainline kernel (in rtw88 driver). Here are kernel patches: https://patchwork.kernel.org/patch/11559307/ https://patchwork.kernel.org/patch/11559297/ https://patchwork.kernel.org/patch/11559301/ https://patchwork.kernel.org/patch/11559299/ https://patchwork.kernel.org/patch/11559303/ https://patchwork.kernel.org/patch/11559295/ https://patchwork.kernel.org/patch/11559293/ And here is the firmware: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=401bd6defb64ebbaf3b020f30f2ac3735d3a0c0f Best regards and have fun!

userofryzen commented 4 years ago

May be the site to test and try is the bug filled in bugzilla...

buboleck commented 4 years ago

Check the dmesg log, it says rfe 2 3 4 etc not supported or something, the driver from Larry Finger repo contains the rfe 2 3 4 etc.

On September 2, 2020 10:11:05 PM GMT+03:00, Krishi Wali notifications@github.com wrote:

@buboleck How do you check which RFE chip you have?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/tomaspinho/rtl8821ce/issues/142#issuecomment-685940891

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

ObserverOfTime commented 4 years ago

the driver from Larry Finger repo contains the rfe 2 3 4 etc.

I've patched the kernel using the changes in the repo but it's still not working, despite not reporting any errors. I'll try disabling the kernel module and installing it from the repo out of tree and see if it works that way.

buboleck commented 4 years ago

Ok, what rfe is your chip? 4 works with very poor reception. 1 and 2 seems to work ok.

On September 2, 2020 10:50:56 PM GMT+03:00, ObserverOfTime notifications@github.com wrote:

the driver from Larry Finger repo contains the rfe 2 3 4 etc.

I've patched the kernel using the changes in the repo but it's still not working, despite not reporting any errors. I'll try disabling the kernel module and installing it from the repo out of tree and see if it works that way.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/tomaspinho/rtl8821ce/issues/142#issuecomment-685960009

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

ObserverOfTime commented 4 years ago

It's RFE 2 and the wireless frequency is 2.4Ghz.

The out-of-tree RTW88 module isn't working either. There's no apparent error in dmesg but I can't connect.

[   10.681357] rtw_core: loading out-of-tree module taints kernel.
[   10.683029] rtw_core: module verification failed: signature and/or required key missing - tainting kernel
[   10.714049] rtw_8821ce 0000:02:00.0: enabling device (0000 -> 0003)
[   10.715481] rtw_8821ce 0000:02:00.0: Firmware version 24.5.0, H2C version 12
[   10.746561] rtw_8821ce 0000:02:00.0 wlo1: renamed from wlan0
[   11.943373] rtw_8821ce 0000:02:00.0: start vif 40:5b:d8:c9:18:f7 on port 0
buboleck commented 4 years ago

Try close to the router, could be the same issue as mine, very low reception.

On September 3, 2020 2:41:39 PM GMT+03:00, ObserverOfTime notifications@github.com wrote:

It's RFE 2 and the wireless frequency is 2.4Ghz.

The out-of-tree RTW88 module isn't working either. There's no apparent error in dmesg but I can't connect.

[   10.681357] rtw_core: loading out-of-tree module taints kernel.
[   10.683029] rtw_core: module verification failed: signature and/or
required key missing - tainting kernel
[   10.714049] rtw_8821ce 0000:02:00.0: enabling device (0000 -> 0003)
[   10.715481] rtw_8821ce 0000:02:00.0: Firmware version 24.5.0, H2C
version 12
[   10.746561] rtw_8821ce 0000:02:00.0 wlo1: renamed from wlan0
[   11.943373] rtw_8821ce 0000:02:00.0: start vif 40:5b:d8:c9:18:f7 on
port 0

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/tomaspinho/rtl8821ce/issues/142#issuecomment-686431869

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

ObserverOfTime commented 4 years ago

You're right! It actually works close to the router.

buboleck commented 4 years ago

Maybe you should also report it to the developers at linux-wireless@vger.kernel.org

On September 3, 2020 3:08:39 PM GMT+03:00, ObserverOfTime notifications@github.com wrote:

You're right! It actually works close to the router.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/tomaspinho/rtl8821ce/issues/142#issuecomment-686444820

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

lwfinger commented 4 years ago

Although the driver in this repo does not report an error for rfe 2, I only changed the table that is read. I did not make any modifications to the rest of the driver, which is likely why you have weak performance.

Yes, you should report this to the Linux Wireless Mailing List. That is the only way such matters will ever be fixed!

ObserverOfTime commented 4 years ago

Apparently I can't report it…

<linux-wireless@vger.kernel.org>: host vger.kernel.org[23.128.96.18] said: 553
    5.7.1 Hello [178.21.23.139], for your MAIL FROM address
    <chronobserver@disroot.org> policy analysis reported: Your address is not
    liked source for email (in reply to MAIL FROM command)
lwfinger commented 4 years ago

You must send plain text mail. No fancy formatting.

A quote regarding this error: "People experience problems when for example From:'',Sender:'' and possible ``Reply-To:'' headers present different addresses."

You might also check http://vger.kernel.org/mxverify.html.

ObserverOfTime commented 4 years ago

It was plain text and only had a From header.

lwfinger commented 4 years ago

You will need to contact the mailing list. Try sending an e-mail to autoanswer@vger.kernel.org. See what happens then.

ObserverOfTime commented 4 years ago

I get the same response.

Kr1sh1 commented 4 years ago

What distro is everyone using for testing this on latest release candidates? I tried using rc3 on Ubuntu but in dmesg it says failed to load firmware. No errors about RFE type.

lwfinger commented 4 years ago

@el-banto: Install the firmware. There is a copy in this repo, otherwise get if from Linux-Firmware, or tell Ubuntu that it is missing.

@ObserverOfTime: Post the complete message (with full headers). Perhaps that will show the error in your E-mail configuration.

JustMaris commented 4 years ago

Installed 5.9-rc4. dmesg | grep rtw error message has new information.

[ 13.139662] rtw_8821ce 0000:01:00.0: enabling device (0000 -> 0003) [ 13.143560] rtw_8821ce 0000:01:00.0: Direct firmware load for rtw88/rtw8821c_fw.bin failed with error -2 [ 13.143565] rtw_8821ce 0000:01:00.0: failed to request firmware [ 13.143571] rtw_8821ce 0000:01:00.0: failed to load firmware [ 13.143573] rtw_8821ce 0000:01:00.0: failed to setup chip efuse info [ 13.143574] rtw_8821ce 0000:01:00.0: failed to setup chip information [ 13.144353] rtw_8821ce: probe of 0000:01:00.0 failed with error -22

EDIT: New, compared to my error message on rc3

ObserverOfTime commented 4 years ago

Do you have the latest firmware?

JustMaris commented 4 years ago

How to check it and how is it possible to update it? Edit: I ran sudo apt-get update & sudo apt-get upgrade & sudo apt-get dist-upgrade. I'm unaware of other methods for updating. On Mon, Sep 7, 2020, 18:05 ObserverOfTime notifications@github.com wrote:

Do you have the latest firmware?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tomaspinho/rtl8821ce/issues/142#issuecomment-688381496, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF574LG5V4VABXSCK7SOMDDSETZFJANCNFSM4NGFHBJA .

lwfinger commented 4 years ago

You can also get it from the git repo at git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git.

In that repo it has a size, date, and md5sum of 137896 May 18 09:30 rtw88/rtw8821c_fw.bin, fb0a5c9cb5615cd80e4a6361225b0897

On the other had, that file is in the rtw88 repo and would be installed on your system with a "make install".

Kr1sh1 commented 4 years ago

To install it I just put the bin file into /lib/firmware/rtw88 Seemed to work, as I was getting the RFE 2 error now, before just failed to load firmware.

mthw0 commented 4 years ago

I've tried Linux 5.9-rc4 (built from source with changed config) and wifi (both 2,4 and 5Ghz) works correctly. I am on Arch Linux.

JustMaris commented 4 years ago

To install it I just put the bin file into /lib/firmware/rtw88 Seemed to work, as I was getting the RFE 2 error now, before just failed to load firmware.

Same situation. After running a make install in the linux firmware newest version, RFE 2 error again, on rc4

buboleck commented 4 years ago

It is expected, no new changes in the driver, it supports rfe 0 and 1

On September 8, 2020 12:10:24 PM GMT+03:00, "Māris Popēns" notifications@github.com wrote:

To install it I just put the bin file into /lib/firmware/rtw88 Seemed to work, as I was getting the RFE 2 error now, before just failed to load firmware.

Same situation. After running a make install in the linux firmware newest version, RFE 2 error again, on rc4

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/tomaspinho/rtl8821ce/issues/142#issuecomment-688733851

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

buboleck commented 4 years ago

To install it I just put the bin file into /lib/firmware/rtw88 Seemed to work, as I was getting the RFE 2 error now, before just failed to load firmware.

Same situation. After running a make install in the linux firmware newest version, RFE 2 error again, on rc4

Report it to linux-wireless@vger.kernel.org

lwfinger commented 4 years ago

I have seen a report that Realtek did not think that RFE 2 versions of at least one of the chips had been released to the public. Unless you report these instances on the linux-wireless mailing list, that problem will never be fixed!

dubhater commented 4 years ago

Some people already emailed linux-wireless about RFE 2 and 4. Should more people chime in about those RFE types? Would that be helpful?

ObserverOfTime commented 4 years ago

Are they aware of the low reception or just the lack of support?

buboleck commented 4 years ago

Are they aware of the low reception or just the lack of support?

I emailed them about both rfe4 and the low reception.

ObserverOfTime commented 4 years ago

v5.9 is now stable and there's still no support for RFE 2.

buboleck commented 4 years ago

v5.9 is now stable and there's still no support for RFE 2.

Nor for RFE 4 in my case...

lwfinger commented 4 years ago

I do not recall any reports of RFE 4 on the linux-wireless mailing list. The RFE2 case for the RTL8821CE has been reported, Realtek has a fix, and will be posting it when verifications have been completed. As I stated on the ML, I will apply the patches here as soon as they are available.

buboleck commented 4 years ago

I do not recall any reports of RFE 4 on the linux-wireless mailing list. The RFE2 case for the RTL8821CE has been reported, Realtek has a fix, and will be posting it when verifications have been completed. As I stated on the ML, I will apply the patches here as soon as they are available.

Ahh... I will email again.

ghost commented 4 years ago

How do I check what RFE my card is and what kernel is this likely to be in (hoping for it to squeeze into fedora 34 or ubuntu 21.04)? Thanks!

dubhater commented 4 years ago

I guess the easiest way would be to boot some live media that has a 5.9 kernel, like the Arch Linux installer. If your card is not supported, the error message from the driver will tell you what RFE it is.

ghost commented 3 years ago

I do not recall any reports of RFE 4 on the linux-wireless mailing list. The RFE2 case for the RTL8821CE has been reported, Realtek has a fix, and will be posting it when verifications have been completed. As I stated on the ML, I will apply the patches here as soon as they are available.

Ahh... I will email again.

I found only 1 email regarding the rfe4 support, and it hasnt gotten any attention at all...

buboleck commented 3 years ago

Was it mine? I emailed several times but got no reply at all.

On November 17, 2020 7:35:57 PM GMT+02:00, MischievousTomato notifications@github.com wrote:

I do not recall any reports of RFE 4 on the linux-wireless mailing list. The RFE2 case for the RTL8821CE has been reported, Realtek has a fix, and will be posting it when verifications have been completed. As I stated on the ML, I will apply the patches here as soon as they are available.

Ahh... I will email again.

I found only 1 email regarding the rfe4 support, and it hasnt gotten any attention at all...

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/tomaspinho/rtl8821ce/issues/142#issuecomment-729086301

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

ghost commented 3 years ago

https://lore.kernel.org/linux-wireless/1A3B6524-C775-4ACB-BF99-CCD9F2700B06@abv.bg/ This is the latest one. Also, we have the same laptop.

ghost commented 3 years ago

Ok so apparently I have an RFE 2 according to the arch iso when it boots up

It says RFE 2 isn't supported is that normal lol.

This is for the kernel 5.9 driver btw not the FOSS driver here.

dubhater commented 3 years ago

Yes, it's not supported yet. Realtek programmers said they will send the patches for RFE 2 soon, after some quality checking.

ghost commented 3 years ago

Yes, it's not supported yet. Realtek programmers said they will send the patches for RFE 2 soon, after some quality checking.

Okay awesome ty for info 👍

Kr1sh1 commented 3 years ago

I wonder why it's taking so long. ETA was 3 weeks ago (if verification passed)

lwfinger commented 3 years ago

How fast could you do all the tests, while carrying on all other work?

ghost commented 3 years ago

I emailed them about rfe4 again, no response ;-;

BigmenPixel0 commented 3 years ago

So far, this driver does not work on RTL8821CE ... Do you know when it will be fixed?

ghost commented 3 years ago

So far, this driver does not work on RTL8821CE ... Do you know when it will be fixed?

Apparently it does on some?

I just want them to make RFE 2 workkk

lwfinger commented 3 years ago

Realtek is working on it. Of course, if you want to debug the problem and suggest a fix, your contributions would be helpful.

BigmenPixel0 commented 3 years ago

Realtek is working on it. Of course, if you want to debug the problem and suggest a fix, your contributions would be helpful.

Is it known in which kernel the driver will work perfectly?

BigmenPixel0 commented 3 years ago

So far, this driver does not work on RTL8821CE ... Do you know when it will be fixed?

Apparently it does on some?

I just want them to make RFE 2 workkk

rtw88_8821ce

hwpfeil commented 3 years ago

This is great news! I intend to archive this repository once the new rtw88 is available in a stable mainline release and proven to be working. "...proven to be working. At this time, in 5.10.2, the rtw88_8821ce driver is not working. Eudev does not trigger and add a link in /sys/net/class for the 8821ce adapter. I still have to use a 5.4 kernel with this module in order to connect to the router (or use a 50' cat-6 cable). RFE 2 still does not work. I don't know why, they've been working on it since last summer.