search

tomaspinho / rtl8821ce

Other
1.6k stars 408 forks source link

Incorrect comparisons with "stop" string #323

Open GrosQuildu opened 1 year ago

GrosQuildu commented 1 year ago

In two places strncmp is called with invalid size argument - either too large or to small:

https://github.com/tomaspinho/rtl8821ce/blob/a3e2f7c1f91e92f2dc788e8fcd7f2986af3d19b6/os_dep/linux/ioctl_mp.c#L1646

https://github.com/tomaspinho/rtl8821ce/blob/a3e2f7c1f91e92f2dc788e8fcd7f2986af3d19b6/os_dep/linux/ioctl_mp.c#L919

tomaspinho commented 1 year ago

Hey! Appreciate the report. Would you be keen on opening a PR with fixes for these? Thanks!