search

tomasr / viasfora

A Visual Studio Extension containing miscellaneous improvements to the editor.
Other
557 stars 90 forks source link

Usage of deprecated IQuickInfoBroker causes VS hangs #342

Closed olegtk closed 1 year ago

olegtk commented 1 year ago

Visual Studio telemetry indicates Viasfora's usage of deprecated IQuickInfoBroker is causing hangs. The solution is to migrate to IAsyncQuickInfoBroker and I'm willing to contribute the fix. Would you be OK to release an update, @tomasr? Thanks!

tomasr commented 1 year ago

I have made here some changes, but I had to completely disable RainbowToolTipPresenter as it doesn't seem like IAsyncQuickInfoSession supports the same functionality as IQuickInfoSession for me to continue supporting this. I am not sure it was ever strictly required (or it might have been trying to fix some cosmetic issues in VS, can't remember anymore). Hopefully doesn't hurt anything...

olegtk commented 1 year ago

Thanks, @tomasr!