tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.83k stars 917 forks source link

docs(contributors) add contributor terrystrachan #346

Closed terrystrachan closed 6 years ago

terrystrachan commented 6 years ago

What:

Adding contributor terrystrachan

Issue number: N/A

tomastrajan commented 6 years ago

Hmm, running npm run contributors:generate should have added new contributor also to the about.component.html template ?

timdeschryver commented 6 years ago

It could be I added the wrong command, in the PR template it's defined as npm run contributors:add.

tomastrajan commented 6 years ago

@timdeschryver both commands are important, first do npm run contributors:add -- <contributor-name> <comma-separated-contributor-contributions> and the run npm run contributors:generate

terrystrachan commented 6 years ago

apologies - i didnt run npm run contributors:generate

timdeschryver commented 6 years ago

Got it, this is all my fault then 😅 I'll update the PR template and will also add a default issue template.