Closed terrystrachan closed 6 years ago
Hmm, running npm run contributors:generate
should have added new contributor also to the about.component.html
template ?
It could be I added the wrong command, in the PR template it's defined as npm run contributors:add
.
@timdeschryver both commands are important, first do npm run contributors:add -- <contributor-name> <comma-separated-contributor-contributions>
and the run npm run contributors:generate
apologies - i didnt run npm run contributors:generate
Got it, this is all my fault then 😅 I'll update the PR template and will also add a default issue template.
What:
Adding contributor terrystrachan
Issue number: N/A