search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 919 forks source link

test(cypress-crudactions): add cypress tests for crud operations, fix… #376

Closed vishalsodani closed 5 years ago

vishalsodani commented 5 years ago

…es #373

What:

Issue number: N/A

timdeschryver commented 5 years ago

PS: feel free to add yourself to the list of contributors npm run contributors:add --vishalsodani test and npm run contributors:generate.

https://www.npmjs.com/package/all-contributors-cli

vishalsodani commented 5 years ago

@timdeschryver Changes done as requested and discussed. Please review.

timdeschryver commented 5 years ago

LGTM, just a few nitpicks.

Thanks for setting the tone for the first cypress tests @vishalsodani 👏 !

vishalsodani commented 5 years ago

LGTM, just a few nitpicks.

Thanks for setting the tone for the first cypress tests @vishalsodani !

Fixed.