search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 919 forks source link

Making the project accessible #388

Closed timdeschryver closed 5 years ago

timdeschryver commented 5 years ago

Describe the feature you'd like:

We added pa11y to run accessibility checks on the website (https://github.com/tomastrajan/angular-ngrx-material-starter/commit/af32ac5046e812d7ca1338d16b7a20a35336ab04). To run these checks, use npm run accessibility and you'll see a overview of the errors.

1_urdmmj38kb8haujy4zwiaq

It would be nice to have these issues solved. For more info see Test for accessibility and help millions of people

The pages that we have to make fully accessible are the following (the urls to check are defined in .pa11yci):

If you want to take a page for your count, leave a comment below.

geromegrignon commented 5 years ago

As the issues are mainly in the app.component, i take them all.

tomastrajan commented 5 years ago

@geromegrignon very appreciated!

tomastrajan commented 5 years ago

Was fixed