search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 919 forks source link

test(form): add form effects tests #390

Closed realtomaszkula closed 5 years ago

realtomaszkula commented 5 years ago

Add missing form effects tests

tomastrajan commented 5 years ago

@zetsnotdead is there a reason why this was implemented with TestBed compared to your other implementation ?

realtomaszkula commented 5 years ago

I implemented it before reading your comment on the other PR. Going with the TestBed was more inline with other specs in the repo, and I considered going for TestBedless specs a bit experimental :laughing:

realtomaszkula commented 5 years ago

@tomastrajan @timdeschryver should I remove the TestBed here as well?

tomastrajan commented 5 years ago

@zetsnotdead yes :)

EDIT: closing of the PR was mistap on the phone 😬😂

realtomaszkula commented 5 years ago

Testbed is gone :)