search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 919 forks source link

refactor(books): books effects spec without the TestBed #392

Closed realtomaszkula closed 5 years ago

realtomaszkula commented 5 years ago

Following up the discussion from #389 I decided to refactor the books effects spec to see how it would end up without the TestBed. @tomastrajan @timdeschryver Thoughts?

tomastrajan commented 5 years ago

@zetsnotdead thanks for all the PRs! I merged most of them but please have a look on Tims comments on the rest of them.

realtomaszkula commented 5 years ago

Fixed everything as requested :)

codecov-io commented 5 years ago

Codecov Report

Merging #392 into master will increase coverage by 0.19%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   86.19%   86.38%   +0.19%     
==========================================
  Files          66       66              
  Lines        1043     1043              
  Branches       46       46              
==========================================
+ Hits          899      901       +2     
+ Misses        129      127       -2     
  Partials       15       15
Impacted Files Coverage Δ
src/app/examples/crud/books.effects.ts 100% <0%> (+11.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0de2722...263887b. Read the comment docs.