search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 919 forks source link

test(auth): remove TestBed from auth effects specs #396

Closed realtomaszkula closed 5 years ago

realtomaszkula commented 5 years ago

Refactored auth effects specs as discussed in #389

tomastrajan commented 5 years ago

@zetsnotdead Your thoughts on the Tims comments?

realtomaszkula commented 5 years ago

Agree with everything. Will fix in the upcoming days. I'm sorry for the delay, but I am busy right now, as I am between jobs and have a lot of phone/in person interviews.

tomastrajan commented 5 years ago

@zetsnotdead thank you for your reply, no worries and wish you a good luck with your job hunt!

timdeschryver commented 5 years ago

Goodluck with the interviews @zetsnotdead! πŸ˜„

realtomaszkula commented 5 years ago

Thank you for the kind comments :heart_eyes: My job search is complete :tada: and I've managed to find some time to fix the specs :) Once again, I apologize it took so long.

codecov-io commented 5 years ago

Codecov Report

Merging #396 into master will increase coverage by 0.09%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   86.19%   86.28%   +0.09%     
==========================================
  Files          66       66              
  Lines        1043     1043              
  Branches       46       46              
==========================================
+ Hits          899      900       +1     
+ Misses        129      128       -1     
  Partials       15       15
Impacted Files Coverage Ξ”
src/app/core/auth/auth.effects.ts 88.88% <0%> (+5.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 0de2722...07af87d. Read the comment docs.

timdeschryver commented 5 years ago

Congrats! πŸŽ‰