fix(app): fix pa11y accessibility issues, fixes #388

[geromegrignon]

Fixes all issues from npm run accessibility #388

@tomastrajan I made only one generic anms string for contributor links (regardless of medium/twitter/linkedin...). Feel free to make more if you want.

i had to write static english aria labels for the Crud "add" button and the Todos "filter" button because the dynamic way failed (i couldn't replicate the issue in other components)

I had to use google translate for languages other than English and French so take the needed time to check it.

(first pull request ever, don't hesitate to give feedback)

[timdeschryver]

Hi @geromegrignon thanks a lot, and great you choose this project to create your first PR! I'll take a look the PR later today.

[timdeschryver]

As example, before:

and after:

[geromegrignon]

fixed several changes requested. I'll keep going tomorrow (i also have to replicate changes i made on accent in default theme file in the other theme files)

[timdeschryver]

Sounds good @geromegrignon, but let's wait on @tomastrajan 's feedback about the contributors generation.

[tomastrajan]

@timdeschryver for contributors generation I wouldn't do anything fancy in the first step, it can be improved in the follow up, but can this be merged?

[timdeschryver]

I think it can be after a rebase.

[tomastrajan]

Hey peeps, I am in the middle of big refactor/ cleanup of this project so many things will move around / be removed as it was getting bit out of hand and it is supposed to be a starter anyway :)

Thank you for your understanding !

[timdeschryver]

Woops, I completely forgot about this PR. Sorry for dropping the ball on this 😅

[tomastrajan]

@timdeschryver no worries! Just got a notification from this PR so replied anyway :)