search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.83k stars 917 forks source link

refactor(notifications): Implemented UI Notifications Service #404

Closed hhubik closed 5 years ago

hhubik commented 5 years ago

Provides a consistent mechanism for displaying self-closing Error, Warning, and Information notifications.

closes #377

hhubik commented 5 years ago

@tomastrajan How is this? Was not completely sure about the SASS/theming stuff.

tomastrajan commented 5 years ago

@hhubik i think it looks pretty great!

tomastrajan commented 5 years ago

Hey @hhubik ! Check out this commit with various minor improvements on your great PR ! Also you can check how it is possible to handle colors in styles variables and how they can be consumed in theme files ;)

Thanks again!

hhubik commented 5 years ago

@tomastrajan I checked it out. Makes sense, as far as I can tell ;) Thanks for the feedback!