tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project

https://tomastrajan.github.io/angular-ngrx-material-starter

MIT License

2.82k stars 919 forks source link

feat(i18n): Reworked translations using BabelEdit 'https://www.codean… #407

Closed kosmas58 closed 5 years ago

kosmas58 commented 5 years ago

What:

Added missing translations. I used BabelEdit to do it. Therefore I had to change some definitions, because they lead to errors in BabelEdit.

codecov-io commented 5 years ago

Codecov Report

Merging #407 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files          66       66           
  Lines        1043     1043           
  Branches       46       46           
=======================================
  Hits          899      899           
  Misses        129      129           
  Partials       15       15

Impacted Files	Coverage Δ
src/app/static/features/features.data.ts	`100% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2fb2a1...bfde2fe. Read the comment docs.

tomastrajan commented 5 years ago

Hi @kosmas58 ! Thank you for your contribution, this looks pretty good.

Just a quick question, are you in some way affiliated with the BabelEdit? I mean it seems like a nice tool but I have never ever before seen somebody putting name and url of a tool in the commit message :)

kosmas58 commented 5 years ago

Hi @tomastrajan, my relation to BabelEdit is, that I'm a paying customer and user of this product. I've been using it in another project, that I'm contributing to.

timdeschryver commented 5 years ago

Seems like a great tool!

tomastrajan commented 5 years ago

@kosmas58 thank you for your explanation and again for the great contribution!

kosmas58 commented 5 years ago

Hi @tomastrajan, thanks for your support and thanks for your project. It helps a lot, when starting an angular material project,.