tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 919 forks source link

test(Form): add happy path #411

Closed timdeschryver closed 5 years ago

timdeschryver commented 5 years ago

What:

Added a happy path test for the form example. This is done with ngx-test-library.

Issue number: N/A

codecov-io commented 5 years ago

Codecov Report

Merging #411 into master will decrease coverage by 27.7%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #411       +/-   ##
===========================================
- Coverage   86.48%   58.77%   -27.71%     
===========================================
  Files          66       66               
  Lines        1043     1043               
  Branches       46       46               
===========================================
- Hits          902      613      -289     
- Misses        126      424      +298     
+ Partials       15        6        -9
Impacted Files Coverage Δ
.../app/examples/stock-market/stock-market.reducer.ts 30% <0%> (-70%) :arrow_down:
src/app/examples/form/form.reducer.ts 33.33% <0%> (-66.67%) :arrow_down:
src/app/core/auth/auth.reducer.ts 33.33% <0%> (-66.67%) :arrow_down:
src/app/settings/settings.reducer.ts 33.33% <0%> (-66.67%) :arrow_down:
src/app/examples/todos/todos.reducer.ts 28.57% <0%> (-64.29%) :arrow_down:
...-reducers/init-state-from-local-storage.reducer.ts 37.5% <0%> (-62.5%) :arrow_down:
...ples/todos/components/todos-container.component.ts 37.09% <0%> (-56.46%) :arrow_down:
src/app/examples/crud/books.reducer.ts 46.15% <0%> (-53.85%) :arrow_down:
...ket/components/stock-market-container.component.ts 50% <0%> (-50%) :arrow_down:
...ettings/components/settings-container.component.ts 44.44% <0%> (-50%) :arrow_down:
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4bf2834...ee3d89d. Read the comment docs.

tomastrajan commented 5 years ago

Also that codecov, that's strange, but haven't investigated yet ...

tomastrajan commented 5 years ago

@timdeschryver merge whenever you're ready ;)

timdeschryver commented 5 years ago

Yea, I was looking at codecov numbers but can't find a reason. Let's see how this evolves...