tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project

https://tomastrajan.github.io/angular-ngrx-material-starter

MIT License

2.83k stars 917 forks source link

Added docker-compose.yml to run the app using docker-compose #412

Closed kosmas58 closed 5 years ago

kosmas58 commented 5 years ago

What:

Added docker-compose.yml to run the app using docker-compose.

codecov-io commented 5 years ago

Codecov Report

Merging #412 into master will increase coverage by 0.19%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   86.73%   86.92%   +0.19%     
==========================================
  Files          66       66              
  Lines        1048     1048              
  Branches       46       46              
==========================================
+ Hits          909      911       +2     
+ Misses        122      120       -2     
  Partials       17       17

Impacted Files	Coverage Δ
src/app/examples/crud/components/crud.component.ts	`64.15% <0%> (+3.77%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 435ca45...acaa0e3. Read the comment docs.

tomastrajan commented 5 years ago

@kosmas58 thank you for your contribution, can you please provide more background / links ? I am not very well versed with the docker technology. Thank you!

kosmas58 commented 5 years ago

@tomastrajan thanks for your reply. To be honest, the benefits of docker-compose for Angular-Material-Starter are small. The main purpose of docker-compose is to orchestrate a series of containers (e.g. a web server with a database server) to generate and start them together. I've added it because it's usually part of my toolset.

I've made the changes to the Dockerfile and .dockerignore because husky otherwise produces error messages under docker run and docker-compose.

tomastrajan commented 5 years ago

@kosmas58 does this have an impact on people who would just want to run in with most basic docker setup? Do they have to have installed something more in their environment?

In general we want stuff to work for the most people possible without getting too specific in one direction and as said before don't really know docker that well so that's why I am asking ;)

kosmas58 commented 5 years ago

@tomastrajan Compose is part of the normal docker installation.

Compose is a tool for defining and running multi-container Docker applications. With Compose, you use a YAML file to configure your application’s services. Then, with a single command, you create and start all the services from your configuration.

The only thing you need to use it, is a docker-compose.yml file, which I've added.

kosmas58 commented 5 years ago

@tomastrajan many thanks for merging it in.