Write tests for untested reducers, actions and effects

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project

https://tomastrajan.github.io/angular-ngrx-material-starter

MIT License

2.83k stars 917 forks source link

Write tests for untested reducers, actions and effects #419

Closed timdeschryver closed 5 years ago

timdeschryver commented 5 years ago

I refactored some parts in https://github.com/tomastrajan/angular-ngrx-material-starter/pull/418 but forgot to write tests 😅 . If someone wants to pick this one up feel free to do so, but leave a comment down below. If no one picks this up during the next weeks, I will create them.

I would be willing to submit a PR to fix this issue:

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

lau32 commented 5 years ago

I can take this up.

timdeschryver commented 5 years ago

That's great to hear @lau32, thanks!