search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 919 forks source link

test(stocks): add valid and invalid stock symbol tests, closes #372 #420

Closed huyen1990 closed 5 years ago

huyen1990 commented 5 years ago

What:

Issue number: N/A

huyen1990 commented 5 years ago

Is it OK now? git comment good also? And how was it closed 9 hours ago? Automatically?

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@eaeddf9). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #420   +/-   ##
=========================================
  Coverage          ?   87.77%           
=========================================
  Files             ?       67           
  Lines             ?      990           
  Branches          ?       41           
=========================================
  Hits              ?      869           
  Misses            ?      103           
  Partials          ?       18

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eaeddf9...84d28f8. Read the comment docs.

tomastrajan commented 5 years ago

LGTM!

@huyen1990 the log says you closed it huyen1990 closed this 11 hours ago but now is open so its alright.