search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 919 forks source link

fix(ngrx): fix e2e / cypress tests, refactor effects #423

Closed tomastrajan closed 5 years ago

tomastrajan commented 5 years ago

Finally :D

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@eaeddf9). Click here to learn what that means. The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #423   +/-   ##
=========================================
  Coverage          ?   87.77%           
=========================================
  Files             ?       67           
  Lines             ?      990           
  Branches          ?       41           
=========================================
  Hits              ?      869           
  Misses            ?      103           
  Partials          ?       18
Impacted Files Coverage Δ
src/app/examples/examples/examples.component.ts 100% <100%> (ø)
src/app/settings/settings.selectors.ts 80% <33.33%> (ø)
src/app/app.component.ts 67.64% <33.33%> (ø)
src/app/settings/settings.effects.ts 89.13% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eaeddf9...1cdf595. Read the comment docs.