tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.83k stars 917 forks source link

feat(docker): dockerfile for production #425

Closed DinoSourcesRex closed 5 years ago

DinoSourcesRex commented 5 years ago

What:

codecov-io commented 5 years ago

Codecov Report

Merging #425 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files          67       67           
  Lines         990      990           
  Branches       41       41           
=======================================
  Hits          869      869           
  Misses        103      103           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 6adbfed...6094d75. Read the comment docs.

tomastrajan commented 5 years ago

@DinoSourcesRex thank you very much for your contribution!

tomastrajan commented 5 years ago

@DinoSourcesRex could you please also update README.md with relevant information for other users ?

DinoSourcesRex commented 5 years ago

@tomastrajan Let me know how that looks.

I can go into more depth on what can be changed by the docker-file if that's something you would like me to do (or add some comments into the dockerfile) - the main things I did not touch upon were changing the environment variables or the port it is being served on, which may be useful.

I've also added some npm scripts to run the production docker commands as they are a bit long-winded.

tomastrajan commented 5 years ago

@DinoSourcesRex I think its pretty great thank you!