Closed DinoSourcesRex closed 5 years ago
Merging #425 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #425 +/- ##
=======================================
Coverage 87.77% 87.77%
=======================================
Files 67 67
Lines 990 990
Branches 41 41
=======================================
Hits 869 869
Misses 103 103
Partials 18 18
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 6adbfed...6094d75. Read the comment docs.
@DinoSourcesRex thank you very much for your contribution!
@DinoSourcesRex could you please also update README.md with relevant information for other users ?
@tomastrajan Let me know how that looks.
I can go into more depth on what can be changed by the docker-file if that's something you would like me to do (or add some comments into the dockerfile) - the main things I did not touch upon were changing the environment variables or the port it is being served on, which may be useful.
I've also added some npm scripts to run the production docker commands as they are a bit long-winded.
@DinoSourcesRex I think its pretty great thank you!
What:
Production.Dockerfile
with 3 stages:npm_builder
so that docker can cache thenpm install
command so it is not re-run every time you make small code changes.builder
which will runbuild:prod
production
which is the final image and will take a freshnode:11.1.0
image, copy the necessary files from thebuilder
stage and then runnode server.js
Production.docker-compose.yml
which can be used to run and build theProduction.Dockerfile
. This can be run withdocker-compose -f Production.docker-compose.yml up
server.js
which will take the port and context from environment variables, if those variables exist. Should not be a breaking change.An update to remove the / and append it on CONTEXT instead so that I can control click the url from my VSCode terminal π
Issue number: #385