search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.83k stars 917 forks source link

prettier does not go deep in folders using "format" scripts #427

Closed akalitenya closed 5 years ago

akalitenya commented 5 years ago

yarn "format:write" and yarn "format:test" does not go deep (recursive) on folders

Minimal reproduction of the bug with instructions:

Expected behavior:

files should be formatted in folders recursively

Other information:

solution: "format:write": "prettier {src,e2e}/**/*.{ts,json,md,scss} --write",

should be rewrited with double quotes

"format:write": "prettier \"{src,e2e}/**/*.{ts,json,md,scss}\" --write"

I would be willing to submit a PR to fix this issue:

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[* ] No

tomastrajan commented 5 years ago

@akalitenya thank you for submitting the issue, I guess it is environment specific as I didn't encounter this problem locally or on Travis CI but we should anyway fix it so that it works for all the users!

tomastrajan commented 5 years ago

Hope you found solution for your issue, this might be outdated as project went through major Angular 8 update. (Old issue cleanup)