search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 918 forks source link

fix: Remove non existing import NotificationStyles in error service #429

Closed Doehl closed 5 years ago

Doehl commented 5 years ago

What:

Remove a non existing import in the error handler service for NotificationStyles.

Can cause an error when typescript compiling the application.

codecov-io commented 5 years ago

Codecov Report

Merging #429 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #429   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files          67       67           
  Lines         990      990           
  Branches       41       41           
=======================================
  Hits          869      869           
  Misses        103      103           
  Partials       18       18
Impacted Files Coverage Δ
...pp/core/error-handler/app-error-handler.service.ts 61.53% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1285a4f...88cfdc0. Read the comment docs.

tomastrajan commented 5 years ago

Hi @Doehl !

Thank you for your contribution! You might considering also running npm run contributors:add -- Doehl code and npm run contributors:generate and commiting it to your PR to appear in the contributors list ;)

Cheers!

Doehl commented 5 years ago

Hi tomatrajan,

Thanks, I have added my self as contributor