search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.83k stars 917 forks source link

add chinese translation #435

Closed wpcfan closed 5 years ago

wpcfan commented 5 years ago

Just add the chinese translation and corresponding languages list

wpcfan commented 5 years ago

for english, it displayed Chinese, others display empty

发自我的 iPhone

在 2018年11月30日，下午5:29，Tim Deschryver notifications@github.com<mailto:notifications@github.com> 写道：

@timdeschryver commented on this pull request.

In src/assets/i18n/fr.jsonhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftomastrajan%2Fangular-ngrx-material-starter%2Fpull%2F435%23discussion_r237795056&data=02%7C01%7C%7Cd3832f927eb644f2ec8d08d656a647ca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636791669493003740&sdata=xq2s%2ByrI2G3GyA%2BwibrxKn6AZYRhA5c51aZhLu7sFtk%3D&reserved=0:

@@ -46,6 +46,7 @@ "anms.settings.general.language.frhttp://anms.settings.general.language.fr": "Français", "anms.settings.general.language.pthttp://anms.settings.general.language.pt-br": "Portugais", "anms.settings.general.language.skhttp://anms.settings.general.language.sk": "Slovaque",

  • "anms.settings.general.language.zh-cn": "",

How does an empty language look like in the UI? Does this map to Chinese, or is it blanc?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftomastrajan%2Fangular-ngrx-material-starter%2Fpull%2F435%23pullrequestreview-180181039&data=02%7C01%7C%7Cd3832f927eb644f2ec8d08d656a647ca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636791669493003740&sdata=mTNaEQS7WFmIabkW8gI0A%2BATd9IAzz7rQT9SbgB%2BX3Q%3D&reserved=0, or mute the threadhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAFNjAwQNGQFluKDN2oVE4YeWAm3Ae8cks5u0PpkgaJpZM4Y7PiQ&data=02%7C01%7C%7Cd3832f927eb644f2ec8d08d656a647ca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636791669493003740&sdata=aeHDAeqdEGbpbxjfWhbnhTyREwLUyhesRSCdsW0rJrk%3D&reserved=0.

codecov-io commented 5 years ago

Codecov Report

Merging #435 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #435   +/-   ##
=======================================
  Coverage   88.35%   88.35%           
=======================================
  Files          68       68           
  Lines        1013     1013           
  Branches       41       41           
=======================================
  Hits          895      895           
  Misses        100      100           
  Partials       18       18
Impacted Files Coverage Δ
...ettings/components/settings-container.component.ts 96% <ø> (ø) :arrow_up:
src/app/app.component.ts 67.64% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa34d70...15a42d4. Read the comment docs.

tomastrajan commented 5 years ago

@wpcfan thank you very much for this!