search

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project
https://tomastrajan.github.io/angular-ngrx-material-starter
MIT License
2.82k stars 918 forks source link

feat(imrove hebrew translation): some improvements for hebrew translation #450

Closed shootermv closed 5 years ago

shootermv commented 5 years ago

What:

Hi, hebrew language is belongs to RTL type languages, thus i decided it will be better to add 'rtl' directive and use it at some pages/ parts of the application

Issue number: N/A

tomastrajan commented 5 years ago

@shootermv thanks! Can you please have a look on failing build?

codecov-io commented 5 years ago

Codecov Report

Merging #450 into master will increase coverage by 0.11%. The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   88.35%   88.46%   +0.11%     
==========================================
  Files          68       69       +1     
  Lines        1013     1032      +19     
  Branches       41       46       +5     
==========================================
+ Hits          895      913      +18     
  Misses        100      100              
- Partials       18       19       +1
Impacted Files Coverage Δ
src/app/shared/shared.module.ts 100% <100%> (ø) :arrow_up:
...rc/app/shared/rtl-support/rtl-support.directive.ts 94.44% <94.44%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d931b1b...d4964fe. Read the comment docs.

shootermv commented 5 years ago

Hi Tomas! Forgot to run prettier again... Now the build is passing

On Thu, Jan 31, 2019 at 9:47 PM Tomas Trajan notifications@github.com wrote:

@shootermv https://github.com/shootermv thanks! Can you please have a look on failing build?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tomastrajan/angular-ngrx-material-starter/pull/450#issuecomment-459480856, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRmHnd0p5b9-7r0BCsfz9GSBJwR39U5ks5vI0hngaJpZM4ac-d7 .

tomastrajan commented 5 years ago

@shootermv thanks!