Update title.service.ts

tomastrajan / angular-ngrx-material-starter

Angular, NgRx, Angular CLI & Angular Material Starter Project

https://tomastrajan.github.io/angular-ngrx-material-starter

MIT License

2.82k stars 918 forks source link

Update title.service.ts #452

Closed DmytroPotapov closed 5 years ago

DmytroPotapov commented 5 years ago

What: Maybe in this case it is worth unsubscribing from observable?

Issue number: N/A

timdeschryver commented 5 years ago

I don't think this is needed because the the service exists as long as the application's life cycle. Thoughts @tomastrajan ?

tomastrajan commented 5 years ago

@DmitriyPotapov I agree with the @timdeschryver here, the service exists for the whole duration of the application life and so there is no reason to make things more complicated. Thanks for your effort and hope you enjoy the starter project!